Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid converting string to color #7769

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Avoid converting string to color #7769

merged 1 commit into from
Jan 22, 2025

Conversation

CarlSchwan
Copy link
Member

Use hex directly

@claucambra claucambra self-assigned this Jan 18, 2025
claucambra
claucambra reviewed Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it an everything looks okay, all the C++ changes LGTM -- just one question

NEXTCLOUD.cmake Outdated Show resolved Hide resolved
@CarlSchwan CarlSchwan force-pushed the perf/color-conversion branch from c618c49 to 0306b3d Compare January 18, 2025 23:46
@claucambra claucambra added this to the 3.15.4 milestone Jan 19, 2025
@claucambra claucambra force-pushed the perf/color-conversion branch from 0306b3d to bc3dcee Compare January 22, 2025 01:52
@claucambra claucambra modified the milestones: 3.15.4, 3.16.0 Jan 22, 2025
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7769-bc3dcee0ece723e55053602edda80a2ce03f3195-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@CarlSchwan @mgallien
Avoid converting string to color
411f88e 
Use hex directly

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@mgallien mgallien force-pushed the perf/color-conversion branch from bc3dcee to 411f88e Compare January 22, 2025 09:42
mgallien
mgallien approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mgallien mgallien enabled auto-merge January 22, 2025 09:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
17 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien disabled auto-merge January 22, 2025 10:16
@mgallien mgallien merged commit a66a5cd into master Jan 22, 2025
12 of 16 checks passed
@mgallien mgallien deleted the perf/color-conversion branch January 22, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien mgallien approved these changes

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@CarlSchwan @nextcloud-desktop-bot @mgallien @claucambra